Skip to content

Conversation

@harding
Copy link
Collaborator

@harding harding commented Sep 3, 2018

Bit of a slow news week, but I think there's still adequate content without resorting to the dregs (but I do have a couple B-list stories I can write up quickly if you think we need a bit more ink).

Note that the tests are expected to fail on this as it includes a link to @marcinja's dashboard blog post which is not present on this branch. @jnewbery I suggest that you do a quick double merge on your local repository and run the tests there before you merge into master; alternatively, that you merge #62 first, restart the tests here, and then merge this PR if the tests pass.

  • Optional: add additional items to dashboard section; if added, optionally update newsletter lede @moneyball

@jnewbery jnewbery force-pushed the 2018-09-04-newsletter branch from c9f3189 to e3891c7 Compare September 4, 2018 14:36
end="77d3ca3ea3ba607e0b08c7921c41bfc0a9658ed2"
%}

- [Bitcoin Core #13126][]: after being deprecated for several major
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong PR number. Should be 12952 for the issue tracking removing the account API or 13825 for the PR that removed the final vestiges of the account code. I think 12952 is better.

@jnewbery
Copy link
Contributor

jnewbery commented Sep 4, 2018

Rebased on top of @marcinja's dashboard post PR and added a fixup commit to fix the PR number for removing accounts.

Will squash Marcin's commits and the newsletter commits before merge.

@jnewbery jnewbery force-pushed the 2018-09-04-newsletter branch from e3891c7 to 0359d29 Compare September 4, 2018 14:41
@jnewbery
Copy link
Contributor

jnewbery commented Sep 4, 2018

tACK 0359d29

Merging. Thanks @harding and @marcinja !

@jnewbery jnewbery merged commit e1febb9 into bitcoinops:master Sep 4, 2018
@jnewbery jnewbery mentioned this pull request Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants