Makefile: test for broken reference-style links #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix broken text in the RSS feed, add excerpt from _posts/en/newsletters/2018-07-24-newsletter.md
jnewbery
reviewed
Nov 8, 2018
Contributor
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
Looks great Dave. One question about the bash command inline.
|
|
||
| test: | ||
| ## Check for broken Markdown reference-style links that are displayed in text unchanged, e.g. [broken][broken link] | ||
| ! find _site/ -name '*.html' | xargs grep ']\[' | grep -v skip-test | grep . |
Contributor
There was a problem hiding this comment.
Is the grep -v skip-test necessary?
Collaborator
Author
There was a problem hiding this comment.
Not yet here, but it's been used to solve issues in other repositories:
user@devbco:~/bitcoincore.org$ git grep skip-test
Makefile: ! find _site/ -name '*.html' | xargs grep ']\[' | grep -v skip-test | grep .
_releases/0.14.0.md:`"proxy"` | `getnetworkinfo()["networks"][0]["proxy"]` <!--skip-test-->
_releases/0.14.0.md:array index or a non-quoted string (i.e. `listunspent()[0][txid]`). <!--skip-test--> Both
bitschmidty
pushed a commit
that referenced
this pull request
Nov 17, 2023
* newsletter276zh * fix style * Apply suggestions from code review Co-authored-by: freeyao <[email protected]> --------- Co-authored-by: Zhiwei(Jeffrey) Hu <[email protected]> Co-authored-by: freeyao <[email protected]>
harding
pushed a commit
to harding/bitcoinops.github.io
that referenced
this pull request
Sep 27, 2024
* newsletter276zh * fix style * Apply suggestions from code review Co-authored-by: freeyao <[email protected]> --------- Co-authored-by: Zhiwei(Jeffrey) Hu <[email protected]> Co-authored-by: freeyao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test that should catch the problem that lead to #79. This is the same test I've used in the BitcoinCore.org repository (and Bitcoin.org before it).
This PR also fixes an incidence of a broken ref-style link, although it only occurred in the HTML metadata for an article. The excerpt used to fix that bug is the same as appears on the site here. This should not result in any user-visible changes to the site (and I don't see any in my quick testing).