Skip to content

Conversation

@gch1p
Copy link

@gch1p gch1p commented Nov 29, 2019

I added a custom Info.plist template with NSPrincipalClass key set to NSApplication. That trick makes the app look sharp on Retina displays.

@bk138
Copy link
Owner

bk138 commented Nov 30, 2019

Thank you very much for the contribution! Isn't this already covered by wxWidgets/wxWidgets#743 ?

Seems this is only in wx 3.1 versions, the latest Homebrew version being 3.0.4, MacPorts has version 3.1.2 though.

Which wxWidgets version are you using for building?


target_link_libraries(${executable_name} MultiVNCgui ${wxWidgets_LIBRARIES} wxservdisc vncclient)

if(APPLE)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should go into the above if (APPLE) stanza and be surrounded by if (wxWidgets_VERSION_STRING LESS 3.1)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work that way:

CMake Error at src/CMakeLists.txt:38 (set_target_properties):
  set_target_properties Can not find target to add properties to: MultiVNC

I guess it doesn't know about the target yet. Have to be after add_executable.

@gch1p
Copy link
Author

gch1p commented Nov 30, 2019

Seems this is only in wx 3.1 versions, the latest Homebrew version being 3.0.4, MacPorts has version 3.1.2 though.

Which wxWidgets version are you using for building?

You're right, I'm using version from Homebrew, which is 3.0.4. I'll add a check.

@bk138
Copy link
Owner

bk138 commented Dec 1, 2019

Merged with minor modifications to endif() clause and commit msg in 28d1dfd. Thank you very much!

May I ask in what context you're using MultiVNC? Which areas need the most improvement?

@bk138 bk138 closed this Dec 1, 2019
@gch1p
Copy link
Author

gch1p commented Dec 1, 2019

Merged with minor modifications to endif() clause and commit msg in 28d1dfd. Thank you very much!

Thanks!

May I ask in what context you're using MultiVNC?

I was installing a couple of OSes on a virtual machine (libvirt, kvm) on my remote Linux server and needed to access their displays. So I configured virt-install to use vnc for graphics output (--graphics vnc), forwarded port to my local host using SSH and... and then I needed to find some good open source VNC client, and your app turned out to be good enough!

Which areas need the most improvement?

I noticed some problems with key capture. Ctrl+C didn't work in shell. I don't know about other shortcuts. I'd say this needs testing and fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants