-
-
Notifications
You must be signed in to change notification settings - Fork 78
macOS: support Retina displays #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you very much for the contribution! Isn't this already covered by wxWidgets/wxWidgets#743 ? Seems this is only in wx 3.1 versions, the latest Homebrew version being 3.0.4, MacPorts has version 3.1.2 though. Which wxWidgets version are you using for building? |
src/CMakeLists.txt
Outdated
|
|
||
| target_link_libraries(${executable_name} MultiVNCgui ${wxWidgets_LIBRARIES} wxservdisc vncclient) | ||
|
|
||
| if(APPLE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should go into the above if (APPLE) stanza and be surrounded by if (wxWidgets_VERSION_STRING LESS 3.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work that way:
CMake Error at src/CMakeLists.txt:38 (set_target_properties):
set_target_properties Can not find target to add properties to: MultiVNC
I guess it doesn't know about the target yet. Have to be after add_executable.
You're right, I'm using version from Homebrew, which is 3.0.4. I'll add a check. |
|
Merged with minor modifications to endif() clause and commit msg in 28d1dfd. Thank you very much! May I ask in what context you're using MultiVNC? Which areas need the most improvement? |
Thanks!
I was installing a couple of OSes on a virtual machine (libvirt, kvm) on my remote Linux server and needed to access their displays. So I configured virt-install to use vnc for graphics output (
I noticed some problems with key capture. Ctrl+C didn't work in shell. I don't know about other shortcuts. I'd say this needs testing and fixing. |
I added a custom
Info.plisttemplate withNSPrincipalClasskey set toNSApplication. That trick makes the app look sharp on Retina displays.