Adjustments for compilation on MSVC and windows compilers in general #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's because there are duplicate #defines, and when Winsock2 is defined before windows.h then windows.h detects that and prevent redefinition. That is the official way stated by Microsoft.
…pilers, MSVC, MINGW32 and other. It even works for x64 and Itanium...
…ilers, because of the size by which it needs to increment/decrement is unknown. We need to define char* in order to increment by measures of 8 bits.
I have added a MACRO that uses either CRITICAL_SECTION or pthread_mutex depeneding on whether it's windows or unix. And because a CRITICAL_SECTION has the bonus of being recursive by default, I've added the recursive attribute to the pthread mutexes.
bk138
added a commit
that referenced
this pull request
Sep 1, 2014
Adjustments for compilation on MSVC and windows compilers in general
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You have a strong dependency on UNIX functions and compilers, and compiling for windows using the MINGW32.
I just wanted to allow a more graceful compatibility for windows, without the MINGW32 dependency.
Now it works :-)