Android: Refactor VNCConn #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of holding a reference VncCanvas, we now pass the required information as arguments.
VNCConn is no longer directly tied to VncCanvas & VncCanvasActivity. It will notify the canvas activity through ObserverInterface.
Contributor
Author
|
Closing this in favor of #56 . It will need some rework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples VNCConn and frame-buffer/bitmap-data from
VncCanvas&VncCanvasActivity.Summary:
VNCConnexposesObserverInterface.VncCanvasActivityimplementsObserverInterface.AbstractBitmapDatadoes not keep a reference toVncCanvas. Instead, required values are passed as method arguments.This would allow us to keep
VNCConnalive insde ViewModel as per #46. (Even if we don't want to go in that direction, this PR allow us to move UI Code out ofVNCConn).