Replace zoom level toast with TextView #73
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I like the original idea with the textview in upper left more, below FAB it kinda feels unintuitive to me. I've 🍒 -picked the relevant commits. Thanks for that nice UI update! |
Contributor
Author
|
No problem! Minor issue: Originally, TextView had White text color and opaque background. When I moved it below FAB, text color was changed to Black and background was made slightly transparent (to match with FAB). Should we apply these changes even now? |
Owner
|
Yeah I noticed. I think its cool as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
I have moved the TextView below FAB to see if they look nice together.
Preview:
