Android: Scaling cleanup #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we are only using ZoomScaling and AbstractScaling only implements one small method.
We now trigger redrawing only when scale is changed.
gujjwal00
force-pushed
the
scaling-cleanup
branch
from
3ec23b9 to
20dd173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors scaling implementation to remove duplicate code and redundant checks.
Changes to current behavior:
Zoom level now appears once at the start of VNC session. This is just a by-product of refactoring. I can remove this if it is unwantedReverted because I don't like this.E: As mentioned in #59 , this is optional refactoring and not a requirement for that.