Hotfix/241 better react 15 compat #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge original repo
…when data changes
Owner
|
Ah that was indeed silly with the early returns, thank you for fixing 💯 That syntax works for a single |
Owner
|
Shipped as v1.15.3 🚀 Thank you again for helping push through this messiness around compat 👍 |
Contributor
Author
|
Np, it was a team effort :-P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where translation is not properly applied when data reference changes, ex:
https://codesandbox.io/s/nifty-wilson-xbfl8
It's also slightly better performant since we only call
Tree.calculateD3Geometry(nextProps);once.