Skip to content

fix: workspace parameter should not be required #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blackchoey merged 4 commits into from
Apr 3, 2024
Merged

fix: workspace parameter should not be required #2

blackchoey merged 4 commits into from
Apr 3, 2024

Conversation

@blackchoey
Copy link
Owner

@blackchoey blackchoey commented Mar 29, 2024

  1. make workspace parameter optional
  2. set workspace parameter default value to default

This change impacts following commands:
apic api update
apic api version update
apic api definition update
apic api deployment update
apic environment update

@arpishahmsft
Copy link
Collaborator

arpishahmsft commented Apr 1, 2024 •
edited
Loading

The idea is that user should not be passing this param at all. Also, the workspace param should be hidden from the user in cli.

If there are any examples, those should be updated

Examples are here:
azure-cli-extensions/src/apic-extension at main · blackchoey/azure-cli-extensions (github.com)
azure-cli-extensions/src/apic-extension/azext_apic_extension/aaz/latest/apic/api/_update.py at main · blackchoey/azure-cli-extensions (github.com)
azure-cli-extensions/src/apic-extension at main · blackchoey/azure-cli-extensions

@blackchoey blackchoey requested a review from arpishahmsft as a code owner April 2, 2024 06:21
@blackchoey
Copy link
Owner Author

blackchoey commented Apr 2, 2024

The idea is that user should not be passing this param at all. Also, the workspace param should be hidden from the user in cli.

If there are any examples, those should be updated

Examples are here: azure-cli-extensions/src/apic-extension at main · blackchoey/azure-cli-extensions (github.com) azure-cli-extensions/src/apic-extension/azext_apic_extension/aaz/latest/apic/api/_update.py at main · blackchoey/azure-cli-extensions (github.com) azure-cli-extensions/src/apic-extension at main · blackchoey/azure-cli-extensions

Thanks, updated.

arpishahmsft
arpishahmsft requested changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@arpishahmsft arpishahmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update examples as well in 2 places I shared to remove workspace param?

Examples are here:
azure-cli-extensions/src/apic-extension at main · blackchoey/azure-cli-extensions (github.com)
azure-cli-extensions/src/apic-extension/azext_apic_extension/aaz/latest/apic/api/_update.py at main · blackchoey/azure-cli-extensions (github.com)

@blackchoey blackchoey merged commit 3eb2b4a into feature-2wk13 Apr 3, 2024
@blackchoey blackchoey deleted the set-default-values-for-workspace-param branch April 3, 2024 04:30
blackchoey added a commit that referenced this pull request Apr 29, 2024
@blackchoey
apic-extension 1.0.0b5 release (Azure#7432)
25109ba 
* fix: --title --kind --custom-property parameters (#1)

* feat: support yaml file in register command (#3)

* fix: workspace parameter should not be required (#2)

* style: fix lint issues (#6)

* chore: update codeowner for apic-extension (#5)

* feat: revert changes to min cli version (#4)

* feat: resolve comments to CLI experience (#10)

* feat: mark "apic api register" command as preview (#13)

* feat: remove --terms-of-service parameter (#12)

* feat: remove --workspace-name parameter (#11)

* feat: support python 3.8 and 3.9 (#14)

* feat: fix command descriptions (#17)

* tests: add test cases for 'apic service' commands (#16)

* feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (#19)

* fix: CLI errors (#20)

* fix: import error when run CLI command

* fix: no workspace name error when run import specification command

* feat: mark some parameters as required (#21)

* feat: mark --assignments parameter required for metadata commands

* doc: update sample commands

* feat: mark --source-resource-ids parameter as required for import-from-apim command

* doc: update description for import-from-apim command

* feat: bump version to 1.0.0b5 and update changelog (#18)

* build: fix ci (#22)

* style: fix style warnings

* test:fix test cases

* fix: service update command failure (#28)

* doc: fix command samples (#30)

* doc: update changelog per feedback (#29)

* doc: remove extra spaces in register command help message (#34)

* doc: update api definition and metadata command samples (#36)
blackchoey added a commit that referenced this pull request Apr 29, 2024
@blackchoey
apic-extension 1.0.0b5 release (Azure#7432)
305949a 
* fix: --title --kind --custom-property parameters (#1)

* feat: support yaml file in register command (#3)

* fix: workspace parameter should not be required (#2)

* style: fix lint issues (#6)

* chore: update codeowner for apic-extension (#5)

* feat: revert changes to min cli version (#4)

* feat: resolve comments to CLI experience (#10)

* feat: mark "apic api register" command as preview (#13)

* feat: remove --terms-of-service parameter (#12)

* feat: remove --workspace-name parameter (#11)

* feat: support python 3.8 and 3.9 (#14)

* feat: fix command descriptions (#17)

* tests: add test cases for 'apic service' commands (#16)

* feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (#19)

* fix: CLI errors (#20)

* fix: import error when run CLI command

* fix: no workspace name error when run import specification command

* feat: mark some parameters as required (#21)

* feat: mark --assignments parameter required for metadata commands

* doc: update sample commands

* feat: mark --source-resource-ids parameter as required for import-from-apim command

* doc: update description for import-from-apim command

* feat: bump version to 1.0.0b5 and update changelog (#18)

* build: fix ci (#22)

* style: fix style warnings

* test:fix test cases

* fix: service update command failure (#28)

* doc: fix command samples (#30)

* doc: update changelog per feedback (#29)

* doc: remove extra spaces in register command help message (#34)

* doc: update api definition and metadata command samples (#36)
frankqianms pushed a commit that referenced this pull request Aug 4, 2025
@bavneetsingh16 @mayankagg9722 @bragi92
[k8s-extension] Update extension CLI to v1.6.5 (Azure#8814)
0ba8c45 
* add pester tests for k8s-extension

* Adding CLI Configuration for DisableInformerCache Flag (#2)

This is required for our helm charts where customers can opt to change the caching behaviour during restore.

* fix testcases for nodepool image issues (#5)

* update readme and version release notes (#6)

* fix: simplify logic and enable correct recording rule groups for managed prom extension (#7)

* remove test cases specific to fork repo

---------

Co-authored-by: Bavneet Singh <[email protected]>
Co-authored-by: Mayank Aggarwal <[email protected]>
Co-authored-by: bragi92 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arpishahmsft arpishahmsft arpishahmsft approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blackchoey @arpishahmsft