chore: bump c-kzg and enable blst portable feature #1059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
approved these changes
Feb 7, 2024
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
lgtm! btw what was the problem without portable?
Collaborator
Author
The issue was this in reth, probably because we built the release binaries on a machine with instructions the user didn't have Portable should allow for architecture or instruction-specific implementations to be selected at runtime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps
c-kzg-4844and enables blst'sportablefeature. The fact that we have to addblstas an optional dependency to do this is a mistake on my part, since we should have introducedportableas a feature inc-kzg-4844directly. Added TODOs for that