fix: replace tuple in sstore return with struct #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiweiii
commented
Feb 21, 2024
| /// Represents the result of an `sstore` operation. | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | ||
| pub struct SStoreResult { |
Contributor
Author
There was a problem hiding this comment.
not sure if this is the right file to place it
Member
There was a problem hiding this comment.
The place is fine, would add more comments.
original: Value of the storage when it is first read
present: Current value of the storage
new_value: Values that that is set
is_cold: Is storage slot loaded from database
rakita
approved these changes
Feb 21, 2024
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
nit on comments otherwise lgtm
Member
|
Clippy not related |
rakita
reviewed
Feb 21, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1114