perf(interpreter): evaluate instruction table constructor at compile time #1140
+56
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time Ideally this would also return `&'static` but since `InstructionTable` is generic over `H`, `&'static InstructionTable<H>` requires `H: 'static`, for which I haven't yet found a work-around.
gakonst
reviewed
Mar 1, 2024
Collaborator
gakonst
left a comment
gakonst
left a comment
There was a problem hiding this comment.
what's the perf change before/after?
rakita
reviewed
Mar 2, 2024
| } | ||
| tables | ||
| }; | ||
| } |
Member
There was a problem hiding this comment.
Didn't know this was possible. Nice one!
llvm got fixed in 1.75 so we could use newest rust.
But will merge this as it is.
rakita
approved these changes
Mar 2, 2024
Merged
fubuloubu
pushed a commit
to ApeWorX/revm
that referenced
this pull request
Apr 11, 2024
…time (bluealloy#1140) Ideally this would also return `&'static` but since `InstructionTable` is generic over `H`, `&'static InstructionTable<H>` requires `H: 'static`, for which I haven't yet found a work-around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally this would also return
&'staticbut sinceInstructionTableis generic overH,&'static InstructionTable<H>requiresH: 'static, for which I haven't yet found a work-around.