Skip to content

Conversation

@mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 8, 2024

finalize is called via the output handler and is supposed to reset the journaledstate.

this ensures the transient storage is also cleared, restoring the initial state of JournaledState

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find!

@rakita rakita merged commit c77fe5a into bluealloy:main Mar 8, 2024
@github-actions github-actions bot mentioned this pull request Mar 7, 2024
rakita pushed a commit that referenced this pull request Mar 9, 2024
* fix: reset tstorage on finalize

* destruct Self

* change order

* Update crates/revm/src/journaled_state.rs
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
* fix: reset tstorage on finalize

* destruct Self

* change order

* Update crates/revm/src/journaled_state.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants