Skip to content

feat(interpreter): expose mutable access methods on stack and memory#1219

Merged
rakita merged 3 commits intobluealloy:mainfrom
DaniPopes:stack-mut
Mar 22, 2024
Merged

feat(interpreter): expose mutable access methods on stack and memory#1219
rakita merged 3 commits intobluealloy:mainfrom
DaniPopes:stack-mut

Conversation

@DaniPopes
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are very sensitive internals,
what's the use case you have in mind here?

@DaniPopes
Copy link
Collaborator Author

DaniPopes commented Mar 22, 2024

We allow mutable access to almost everything else, like the bytecode raw ptr, we either lock everything or nothing

I want to clear stack and memory to run it in a standalone loop

@mattsse
Copy link
Collaborator

mattsse commented Mar 22, 2024

We allow mutable access to almost everything else

fair, not opposed to this, so defer to @rakita here

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 1ce5a52 into bluealloy:main Mar 22, 2024
@github-actions github-actions bot mentioned this pull request Mar 22, 2024
@DaniPopes DaniPopes deleted the stack-mut branch March 22, 2024 21:42
This was referenced Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants