Skip to content

feat: adjust gas-costs for EIP-2935 BLOCKHASH#1422

Merged
DaniPopes merged 1 commit intobluealloy:mainfrom
DaniPopes:eip2935-gas
May 16, 2024
Merged

feat: adjust gas-costs for EIP-2935 BLOCKHASH#1422
DaniPopes merged 1 commit intobluealloy:mainfrom
DaniPopes:eip2935-gas

Conversation

@DaniPopes
Copy link
Collaborator

Don't pay for SLOAD.

Ref ethereum/EIPs#8564

Copy link
Collaborator

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - onbjerg

@DaniPopes
Copy link
Collaborator Author

ty boss

@DaniPopes DaniPopes merged commit 6e81b88 into bluealloy:main May 16, 2024
@DaniPopes DaniPopes deleted the eip2935-gas branch May 16, 2024 13:41
@github-actions github-actions bot mentioned this pull request May 16, 2024
let Some((value, _)) = host.sload(BLOCKHASH_STORAGE_ADDRESS, index) else {
interpreter.instruction_result = InstructionResult::FatalExternalError;
return;
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this okay, it will warm load the storage?

This was referenced May 17, 2024
This was referenced Jun 3, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants