fix: check for canonical Fp elements in MSM #1445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This is not a bug, geth does not actually check that scalars used are canonical Fr elements because it uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks that the scalar values being used in precompiles are canonical, as in, they are valid Fr elements. A similar check is performed in
c-kzg-4844here: https://github.com/ethereum/c-kzg-4844/blob/5b35b6147bf269b16c1bffd268fd03bac0c00b64/src/c_kzg_4844.c#L544This could have been particularly bad, as geth (and other implementations) would have rejected certain scalar values that we would not have.EDIT: see below