Skip to content

Conversation

@yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented May 21, 2024

Since the db may be a remote db, it could happen a network error under the db error.
And when remote db error happen, the application level maybe need to retry it. So it's better to keep db error original rather than be a custom string.

Or just return another db error with extra error info?

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems resonable.
cc @refcell

@rakita
Copy link
Member

rakita commented May 24, 2024

failed tests not related

@rakita rakita merged commit c755977 into bluealloy:main May 24, 2024
This was referenced Jun 8, 2024
This was referenced Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants