Skip to content

Conversation

@rakita
Copy link
Member

@rakita rakita commented May 27, 2024

wrong block number used.

Introduced in https://github.com/bluealloy/revm/pull/1427/files in EF interop
Bug found here: holiman/goevmlab#151

ty @holiman

@github-actions
Copy link
Contributor

Valgrind Results:

==3856== Cachegrind, a cache and branch-prediction profiler
==3856== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3856== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3856== Command: target/release/snailtracer
==3856== 
--3856-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.821682145s
==3856== 
==3856== I   refs:      429,372,420
==3856== I1  misses:          3,298
==3856== LLi misses:          2,799
==3856== I1  miss rate:        0.00%
==3856== LLi miss rate:        0.00%
==3856== 
==3856== D   refs:      206,205,299  (133,650,799 rd   + 72,554,500 wr)
==3856== D1  misses:        344,440  (    204,399 rd   +    140,041 wr)
==3856== LLd misses:        137,607  (      4,259 rd   +    133,348 wr)
==3856== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3856== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3856== 
==3856== LL refs:           347,738  (    207,697 rd   +    140,041 wr)
==3856== LL misses:         140,406  (      7,058 rd   +    133,348 wr)
==3856== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit af88ee9 into main May 27, 2024
@rakita rakita deleted the rakita/fix_blockhash_instr branch June 1, 2024 12:54
This was referenced Jun 3, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants