refactor: replace U256 with u64 in BLOCKHASH #1505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
Jun 11, 2024
crates/revm/src/context.rs
Outdated
| fn block_hash(&mut self, number: u64) -> Option<B256> { | ||
| let block_number = as_usize_saturated!(self.env().block.number); | ||
| let requested_number = as_usize_saturated!(number); | ||
| let requested_number = number as usize; |
Member
There was a problem hiding this comment.
This can panic. We should use usize::try_from(number).unwrap_or(usize::MAX);
rakita
requested changes
Jun 11, 2024
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
cool change. One edge case pending
Contributor
Author
|
@rakita thanks for your review, I've refactored accordingly. |
TropicalDog17
force-pushed
the
tuan/refactor-blockhash
branch
from
cf48fd3 to
4d3faae
Compare
DaniPopes
changed the title
DaniPopes
approved these changes
Jun 12, 2024
This was referenced Jun 20, 2024
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the type of the number parameter in the block_hash methods of Host and Database from U256 to u64.
Closes #1423
\cc @rakita @DaniPopes