Skip to content

Conversation

@impactdni2
Copy link
Contributor

Reduces allocations in a two places.

  1. In ExecutionHandler::call(), drops a .clone() on the inputs (allocated cloned Bytes)
  2. In Interpreter::insert_call_outcome, re-uses the passed in call_outcome.result.output rather than cloning the Bytes into a the new location

All the tests pass as far as I can tell, but I'm getting a bit lower in the stack than I'm super comfortable in, so would love an extra set of eyes to tell me if I'm missing something.

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 0768ec6 into bluealloy:main Jun 11, 2024
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants