Skip to content

fix(EOF): Remove redundunt ext call gas cost #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakita merged 7 commits into from
Jun 11, 2024
Merged

fix(EOF): Remove redundunt ext call gas cost #1513

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7081c15
feat(revme): add prague spec
rakita Jun 11, 2024
437d7cb
fix(EOF): jumpf gas was changes
rakita Jun 11, 2024
4a65467
fix(EOF): extstaticcall make static
rakita Jun 11, 2024
8c96da1
fix(EOF): add DATACOPY copy gas
rakita Jun 11, 2024
866a6bc
fix(EOF): Remove redundunt ext call gas cost
rakita Jun 11, 2024
1e593f5
Merge remote-tracking branch 'origin/main'
rakita Jun 11, 2024
690a202
Merge branch 'main' into rakita/extcall_cold_cost
rakita Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions crates/interpreter/src/instructions/contract.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,6 @@ pub fn extcall_gas_calc<H: Host + ?Sized>(
return None;
};

if load_result.is_cold {
gas!(interpreter, gas::COLD_ACCOUNT_ACCESS_COST, None);
}

// TODO(EOF) is_empty should only be checked on delegatecall
let call_cost = gas::call_cost(
BerlinSpec::SPEC_ID,
Expand All @@ -187,8 +183,6 @@ pub fn extcall_gas_calc<H: Host + ?Sized>(
return None;
}

// TODO check remaining gas more then N

gas!(interpreter, gas_limit, None);
Some(gas_limit)
}
Expand Down