feat(EOF): Put EOF bytecode behind an Arc #1517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpgonzalezra
changed the title
jpgonzalezra
force-pushed
the
jpgonzalezra/1488
branch
2 times, most recently
from
7f49501 to
1fc6b5d
Compare
jpgonzalezra
force-pushed
the
jpgonzalezra/1488
branch
from
1fc6b5d to
27f582e
Compare
Contributor
Author
|
I'm taking a look at why the tests are failing, it seems to be something else and not the changes made here |
Member
It is a malformed json file ethereum/tests#1384 It is not related to this PR. |
jpgonzalezra
changed the title
rakita
approved these changes
Jun 15, 2024
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
lgtm!
btw there are keywords that github understands that are good to use https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue
rakita
changed the title
Closed
Contributor
Author
|
Thanks for the comment, I'm going to start doing it. |
This was referenced Jun 17, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the ISSUE
DaniPopes: EOF structure is present inside of Bytecode, and is cloned internally in AccountInfo and other places. It would improve performance to put behind an Arc to avoid cloning the underlying memory.
cc: @rakita @DaniPopes