Skip to content

Conversation

@DaniPopes
Copy link
Collaborator

const {} blocks were stabilized yesterday as part of 1.79.

I would've liked to make the instruction table &'static but unfortunately that requires H: 'static even if it's through a function pointer.

Copy link
Collaborator

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need msrv bump?

@DaniPopes
Copy link
Collaborator Author

Revm has no MSRV, but yes it would be a bump from 1.75 (I just tried cargo msrv on main b988a0f)

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rakita
Copy link
Member

rakita commented Jun 15, 2024

Will publish a new version of revm soon, so I will merge this PR after this.

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita
Copy link
Member

rakita commented Jun 22, 2024

Failed tests not related

@rakita rakita merged commit a51d53b into bluealloy:main Jun 22, 2024
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
@DaniPopes DaniPopes deleted the const-blocks branch June 22, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants