Skip to content

feat: pass interpreter into Inspector::log #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakita merged 1 commit into from
Jul 15, 2024
Merged

feat: pass interpreter into Inspector::log #1610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/revm/src/inspector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ pub trait Inspector<DB: Database> {

/// Called when a log is emitted.
#[inline]
fn log(&mut self, context: &mut EvmContext<DB>, log: &Log) {
fn log(&mut self, interp: &mut Interpreter, context: &mut EvmContext<DB>, log: &Log) {
let _ = interp;
let _ = context;
let _ = log;
}
Expand Down
4 changes: 2 additions & 2 deletions crates/revm/src/inspector/gas.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ mod tests {
self.gas_inspector.step(interp, context);
}

fn log(&mut self, context: &mut EvmContext<DB>, log: &Log) {
self.gas_inspector.log(context, log);
fn log(&mut self, interp: &mut Interpreter, context: &mut EvmContext<DB>, log: &Log) {
self.gas_inspector.log(interp, context, log);
}

fn step_end(&mut self, interp: &mut Interpreter, context: &mut EvmContext<DB>) {
Expand Down
4 changes: 3 additions & 1 deletion crates/revm/src/inspector/handler_register.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ pub fn inspector_handle_register<DB: Database, EXT: GetInspector<DB>>(
// that log can be found as journaled_state.
let last_log = host.evm.journaled_state.logs.last().unwrap().clone();
// call Inspector
host.external.get_inspector().log(&mut host.evm, &last_log);
host.external
.get_inspector()
.log(interpreter, &mut host.evm, &last_log);
}
});
}
Expand Down