Move optimism-specific bn128 precompile

crates/precompile/src/bn128.rs

@@ -45,23 +45,7 @@ pub mod mul {
 pub mod pair {
     use super::*;
 
-    const ADDRESS: Address = crate::u64_to_address(8);
-
-    pub const GRANITE_MAX_INPUT_SIZE: usize = 112687;
-    pub const GRANITE: PrecompileWithAddress = PrecompileWithAddress(
-        ADDRESS,
-        Precompile::Standard(|input, gas_limit| {
-            if input.len() > GRANITE_MAX_INPUT_SIZE {
-                return Err(Error::Bn128PairLength.into());
-            }
-            run_pair(
-                input,
-                ISTANBUL_PAIR_PER_POINT,
-                ISTANBUL_PAIR_BASE,
-                gas_limit,
-            )
-        }),
-    );
+    pub const ADDRESS: Address = crate::u64_to_address(8);
 
     pub const ISTANBUL_PAIR_PER_POINT: u64 = 34_000;
     pub const ISTANBUL_PAIR_BASE: u64 = 45_000;

crates/revm/src/optimism.rs

@@ -1,5 +1,6 @@
 //! Optimism-specific constants, types, and helpers.
 
+mod bn128;
 mod fast_lz;
 mod handler_register;
 mod l1block;

crates/revm/src/optimism/bn128.rs

@@ -0,0 +1,85 @@
+use revm_precompile::bn128;
+use revm_precompile::{Error, Precompile, PrecompileResult, PrecompileWithAddress};
+
+pub(crate) mod pair {
+    use super::*;
+
+    const GRANITE_MAX_INPUT_SIZE: usize = 112687;
+    pub(crate) const GRANITE: PrecompileWithAddress = PrecompileWithAddress(
+        bn128::pair::ADDRESS,
+        Precompile::Standard(|input, gas_limit| run_pair(input, gas_limit)),
+    );
+
+    pub(crate) fn run_pair(input: &[u8], gas_limit: u64) -> PrecompileResult {
+        if input.len() > GRANITE_MAX_INPUT_SIZE {
+            return Err(Error::Bn128PairLength.into());
+        }
+        bn128::run_pair(
+            input,
+            bn128::pair::ISTANBUL_PAIR_PER_POINT,
+            bn128::pair::ISTANBUL_PAIR_BASE,
+            gas_limit,
+        )
+    }
+}
+
+#[cfg(test)]
+mod tests {
+    use revm_precompile::primitives::{hex, PrecompileErrors};
+
+    use super::*;
+
+    #[test]
+    fn test_bn128_pair() {
+        let input = hex::decode(
+            "\
+      1c76476f4def4bb94541d57ebba1193381ffa7aa76ada664dd31c16024c43f59\
+      3034dd2920f673e204fee2811c678745fc819b55d3e9d294e45c9b03a76aef41\
+      209dd15ebff5d46c4bd888e51a93cf99a7329636c63514396b4a452003a35bf7\
+      04bf11ca01483bfa8b34b43561848d28905960114c8ac04049af4b6315a41678\
+      2bb8324af6cfc93537a2ad1a445cfd0ca2a71acd7ac41fadbf933c2a51be344d\
+      120a2a4cf30c1bf9845f20c6fe39e07ea2cce61f0c9bb048165fe5e4de877550\
+      111e129f1cf1097710d41c4ac70fcdfa5ba2023c6ff1cbeac322de49d1b6df7c\
+      2032c61a830e3c17286de9462bf242fca2883585b93870a73853face6a6bf411\
+      198e9393920d483a7260bfb731fb5d25f1aa493335a9e71297e485b7aef312c2\
+      1800deef121f1e76426a00665e5c4479674322d4f75edadd46debd5cd992f6ed\
+      090689d0585ff075ec9e99ad690c3395bc4b313370b38ef355acdadcd122975b\
+      12c85ea5db8c6deb4aab71808dcb408fe3d1e7690c43d37b4ce6cc0166fa7daa",
+        )
+        .unwrap();
+        let expected =
+            hex::decode("0000000000000000000000000000000000000000000000000000000000000001")
+                .unwrap();
+        let outcome = pair::run_pair(&input, 260_000).unwrap();
+        assert_eq!(outcome.bytes, expected);
+
+        // invalid input length
+        let input = hex::decode(
+            "\
+          1111111111111111111111111111111111111111111111111111111111111111\
+          1111111111111111111111111111111111111111111111111111111111111111\
+          111111111111111111111111111111\
+      ",
+        )
+        .unwrap();
+
+        let res = pair::run_pair(&input, 260_000);
+        assert!(matches!(
+            res,
+            Err(PrecompileErrors::Error(Error::Bn128PairLength))
+        ));
+
+        // valid input length shorter than 112687
+        let input = vec![1u8; 586 * bn128::PAIR_ELEMENT_LEN];
+        let res = pair::run_pair(&input, 260_000);
+        assert!(matches!(res, Err(PrecompileErrors::Error(Error::OutOfGas))));
+
+        // input length longer than 112687
+        let input = vec![1u8; 587 * bn128::PAIR_ELEMENT_LEN];
+        let res = pair::run_pair(&input, 260_000);
+        assert!(matches!(
+            res,
+            Err(PrecompileErrors::Error(Error::Bn128PairLength))
+        ));
+    }
+}

crates/revm/src/optimism/handler_register.rs

@@ -15,7 +15,7 @@ use crate::{
     Context, ContextPrecompiles, FrameResult,
 };
 use core::ops::Mul;
-use revm_precompile::{bn128, secp256r1, PrecompileSpecId};
+use revm_precompile::{secp256r1, PrecompileSpecId};
 use std::string::ToString;
 use std::sync::Arc;
 
@@ -159,7 +159,7 @@ pub fn load_precompiles<SPEC: Spec, EXT, DB: Database>() -> ContextPrecompiles<D
     if SPEC::enabled(SpecId::GRANITE) {
         precompiles.extend([
             // Restrict bn256Pairing input size
-            bn128::pair::GRANITE,
+            optimism::bn128::pair::GRANITE,
         ])
     }