perf(precompile): use secp256k1 global context for ecrecover #1843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Nov 1, 2024
DaniPopes
approved these changes
Nov 1, 2024
mattsse
approved these changes
Nov 1, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
we should also send this to release/v50
because this is the branch that's being released
rakita
approved these changes
Nov 4, 2024
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
lgtm, test failing not related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing a new
Secp256k1instance ever ecrecover call ends up dominating execution time, because of the randomization. This now uses the global context, avoiding randomization overhead.Samply profiles from https://share.firefox.dev/4hwBrXj
