Skip to content

perf(CacheAccount): remove unneeded clone #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakita merged 1 commit into from
Nov 20, 2024
Merged

perf(CacheAccount): remove unneeded clone #1859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/database/src/states/cache_account.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,11 @@ impl CacheAccount {
storage: StorageWithOriginalValues,
) -> TransitionAccount {
let previous_status = self.status;
let previous_info = self.account.as_ref().map(|a| a.info.clone());
let mut this_storage = self
.account
.take()
.map(|acc| acc.storage)
.unwrap_or_default();
let (previous_info, mut this_storage) = if let Some(account) = self.account.take() {
(Some(account.info), account.storage)
} else {
(None, Default::default())
};

this_storage.extend(storage.iter().map(|(k, s)| (*k, s.present_value)));
let changed_account = PlainAccount {
Expand Down
Loading