Skip to content

feat: Removed create address collision check #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakita merged 1 commit into from
Dec 19, 2024
Merged

feat: Removed create address collision check #1928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions crates/handler/src/frame.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,6 @@ where
}
};

// created address is not allowed to be a precompile.
// TODO add precompile check
if precompile.contains(&created_address) {
return return_error(InstructionResult::CreateCollision);
}

// warm load account.
context.journal().load_account(created_address)?;

Expand Down Expand Up @@ -392,11 +386,6 @@ where

let created_address = created_address.unwrap_or_else(|| inputs.caller.create(old_nonce));

// created address is not allowed to be a precompile.
if precompile.contains(&created_address) {
return return_error(InstructionResult::CreateCollision);
}

// Load account so it needs to be marked as warm for access list.
context.journal().load_account(created_address)?;

Expand Down
Loading