Skip to content

Conversation

@meyer9
Copy link
Contributor

@meyer9 meyer9 commented Jan 10, 2025

This will allow calling estimate_tx_compressed_size for the purpose of adding DA size limits to the OP sequencer. Example usage here: https://github.com/paradigmxyz/reth/pull/13757/files#diff-fc959a93a8c46daf00cdff39ee39f8c1c18d36cd482a50a300294000cea38c37R82

I can also move this function to a separate file if that's desired - just lmk!

Also, I'm assuming we'll publish this package on the next release? I don't see a revm-optimism package on crates.io yet.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 10, 2025

CodSpeed Performance Report

Merging #1985 will not alter performance

Comparing meyer9:meyer9/move-op-tx-compressed-size-calc (b2fdf86) with main (a2451cd)

Summary

✅ 8 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Maybe it makes sense to move all tx_ to transaction.rs as they depend mostly on input

Crates should be released in upcoming weeks. Currently, there is a branch where old API is still maintained for projects that didn't integrate with main.

@rakita rakita merged commit 9bef7d9 into bluealloy:main Jan 10, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants