Skip to content

Conversation

@klkvr
Copy link
Collaborator

@klkvr klkvr commented Feb 17, 2025

Ideally consumers should be able to access any item from revm crate like it was before. Right now this is not possible due to revm-inspector depending on revm itself

Chnges in this PR:

  • ExecuteEvm and ExecuteCommitEvm traits are moved to revm-handler
  • Instead of depending on revm, revm-inspector now depends on specific crates
  • context-interface is re-exported from context
  • database-interface is re-exported from database
  • database and inspector are re-exported from revm

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 17, 2025

CodSpeed Performance Report

Merging #2088 will not alter performance

Comparing klkvr/reexport-inspector (5d89010) with main (f463fb8)

Summary

✅ 8 untouched benchmarks

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense,

#[cfg(not(feature = "std"))]
extern crate alloc as std;

pub use context_interface::*;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool


[dependencies]
# revm
database.workspace = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use database-interface here

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left one nit

@klkvr klkvr merged commit 6662e10 into main Feb 18, 2025
27 checks passed
This was referenced Feb 25, 2025
@rakita rakita mentioned this pull request Feb 27, 2025
This was referenced Mar 4, 2025
@rakita rakita deleted the klkvr/reexport-inspector branch May 8, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants