-
Notifications
You must be signed in to change notification settings - Fork 966
refactor: re-export all crates from revm
#2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #2088 will not alter performanceComparing Summary
|
mattsse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense,
| #[cfg(not(feature = "std"))] | ||
| extern crate alloc as std; | ||
|
|
||
| pub use context_interface::*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool
crates/handler/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| # revm | ||
| database.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can use database-interface here
rakita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, left one nit
Ideally consumers should be able to access any item from
revmcrate like it was before. Right now this is not possible due torevm-inspectordepending onrevmitselfChnges in this PR:
ExecuteEvmandExecuteCommitEvmtraits are moved to revm-handlerrevm,revm-inspectornow depends on specific cratescontext-interfaceis re-exported fromcontextdatabase-interfaceis re-exported fromdatabasedatabaseandinspectorare re-exported fromrevm