Skip to content

Conversation

@klkvr
Copy link
Collaborator

@klkvr klkvr commented Feb 18, 2025

Right now this is defined but never called which results in tx cached values not being reset for op

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 18, 2025

CodSpeed Performance Report

Merging #2091 will not alter performance

Comparing klkvr/clear (a8a9893) with main (cd6ebd8)

Summary

✅ 8 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would refactor it slightly, so clear is called every time even if a error happens

But for now, lets merge it as it fixes the problem

@rakita rakita merged commit c525b5e into main Feb 18, 2025
28 checks passed
This was referenced Feb 18, 2025
@rakita rakita deleted the klkvr/clear branch February 19, 2025 07:41
This was referenced Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants