feat: add constructor with hardfork #2135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
CodSpeed Performance ReportMerging #2135 will not alter performanceComparing Summary
|
rakita
reviewed
Mar 3, 2025
crates/context/src/cfg.rs
Outdated
| CfgEnv { | ||
| chain_id: self.chain_id, | ||
| limit_contract_code_size: self.limit_contract_code_size, | ||
| pub fn with_spec(spec: SPEC) -> Self { |
Member
There was a problem hiding this comment.
Suggested change
| pub fn with_spec(spec: SPEC) -> Self { | |
| pub fn new_with_spec(spec: SPEC) -> Self { |
Functions that create the object are more obvious if they start with new_
and would be good to leave previous functions
Contributor
Author
There was a problem hiding this comment.
Resolved by 6d8ed5a
FYI, I chose the with_* function name as this naming convention is commonplace for constructors in the STL. E.g. Vec::with_capacity.
rakita
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an API that allows construction of a
CfgEnvwith aSpecId. This is useful when using aSpecIdtype that doesn't implementDefault.The changes avoid duplication of default parameters by calling
with_specfromfn default.