Skip to content

Conversation

@klkvr
Copy link
Collaborator

@klkvr klkvr commented Mar 5, 2025

we should always use primitives::HashMap vs primitives::hash_map::HashMap as hash_map::HashMap might have different default hasher generic

this was changed in #2131

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 5, 2025

CodSpeed Performance Report

Merging #2148 will not alter performance

Comparing klkvr/fix-hashmap (6d51b47) with main (dd8c1c0)

Summary

✅ 8 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 934b774 into main Mar 5, 2025
28 checks passed
This was referenced Mar 5, 2025
@rakita rakita deleted the klkvr/fix-hashmap branch May 8, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants