Skip to content

Conversation

@argentpapa
Copy link
Contributor

@argentpapa argentpapa commented Mar 16, 2025

ref: #1754 replaced structopt with clap
updates deprecated #[clap(...)] attributes to their modern equivalents in clap 4.x.

logs:

warning: use of deprecated function `<cmd::statetest::Cmd as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> bins/revme/src/cmd/statetest.rs:19:7
   |
19 |     #[clap(required = true, num_args = 1..)]
   |       ^^^^
   |
   = note: `#[warn(deprecated)]` on by default

warning: use of deprecated function `<cmd::statetest::Cmd as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> bins/revme/src/cmd/statetest.rs:22:7
   |
22 |     #[clap(short = 's', long)]
   |       ^^^^

warning: use of deprecated function `<cmd::statetest::Cmd as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> bins/revme/src/cmd/statetest.rs:27:7
   |
27 |     #[clap(long)]
   |       ^^^^

warning: use of deprecated function `<cmd::statetest::Cmd as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> bins/revme/src/cmd/statetest.rs:34:7
   |
34 |     #[clap(short = 'o', long)]
   |       ^^^^

warning: use of deprecated function `<cmd::statetest::Cmd as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]`
  --> bins/revme/src/cmd/statetest.rs:37:7
   |
37 |     #[clap(long, alias = "no-fail-fast")]
   |       ^^^^

warning: `revme` (lib) generated 5 warnings

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 16, 2025

CodSpeed Performance Report

Merging #2217 will not alter performance

Comparing argentpapa:main (22b5b3d) with main (f742477)

Summary

✅ 8 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice bump!

@rakita rakita merged commit cdc0af0 into bluealloy:main Mar 17, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants