chore(experiment): refactor blake2 input parsing #2734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
changed the title
CodSpeed Performance ReportMerging #2734 will degrade performances by 6.92%Comparing Summary
Benchmarks breakdown
|
Contributor
Author
|
running perfblake locally implied that this was faster, however when comparing to master using codspeed, its slightly slower: #2735 (comment) |
Contributor
Author
|
Adding 100K and 200K rounds to have larger inputs to confirm |
rakita
reviewed
Jul 21, 2025
| let flags = set4(count_low(count), count_high(count), last_block, last_node); | ||
| let mut d = xor(loadu(iv_high), flags); | ||
|
|
||
| let block: &[u8; BLOCKBYTES] = std::mem::transmute(block); |
Member
There was a problem hiding this comment.
This is probably fine as endiness is the same for all targets that have avx
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.