perf: interpreter improvements #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more accessed than host, and when calling a function that takes interpreter as the first argument, no registers have to change.
This function massively bloats all callsites because it can drop the previous action.
We want to write directly into the maybe-uninitialized memory of the stack. We cannot do this using existing APIs, so we must add `push_slice` to `StackTr`.
CodSpeed Performance ReportMerging #2760 will improve performances by 33.39%Comparing Summary
Benchmarks breakdown
|
Reintroduce bluealloy#1361.
Collaborator
|
das feuer bruder |
mattsse
reviewed
Jul 22, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
🔥 all of this checks out afaict
The compiler does not elide the "not Some" check after inlining `popn_top`. See rust-lang/rust#144329.
Move runtime checks to debug mode only.
Member
|
Awesome finds! It looks that the biggest thing is marking it is unfortunate that degradation didn't happened on PR when this fn was introduced but in EOF removal PR where code was removed, I guess with code removed the compiler switched its strategy for this fn from not inlining to inlining. |
rakita
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various interpreter improvements. See individual commits.