Instruction table #759
Merged
Instruction table #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Oct 2, 2023
| table | ||
| } | ||
|
|
||
| pub fn make_instruction_table<H: Host, SPEC: Spec>() -> [Instruction<H>; 256] { |
Collaborator
There was a problem hiding this comment.
I think this and instruction can be made const
Member
Author
There was a problem hiding this comment.
Tried it and the problem it with Host it errors with something like "cant use parent generic" or something in that tone.
rakita
force-pushed
the
instruction_table
branch
6 times, most recently
from
ed2d9cc to
dec5e97
Compare
rakita
force-pushed
the
instruction_table
branch
from
dec5e97 to
f988330
Compare
Closed
This was referenced Feb 8, 2024
Merged
This was referenced Feb 16, 2024
Closed
Merged
This was referenced Feb 24, 2024
Merged
This was referenced Mar 8, 2024
Merged
This was referenced Mar 22, 2024
Closed
Closed
Closed
Merged
This was referenced Apr 2, 2024
Merged
This was referenced Apr 16, 2024
This was referenced May 2, 2024
Closed
This was referenced May 13, 2024
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put all instructions in the table and allow the table to be initialized. This is the first step towards introduction of custom opcodes.
Additionally, specify a Boxed instruction that is a little bit less performant (10-20%) but allows the use of closure over instructions.
An example of boxed instruction is used for
Inspector, this is a step forward in having custom handles for some or all instructions.The plain instruction table had the same performance as the previous eval fn that used
match(0.01% invariance with cachegrind)Removed generic of
INSTRUCTIONas benefits are neglectable, and code clarity is increased. Now EVMImpl hasOptionover instruction which is a lot nicer.Removed
stepandstep_endfromHosttrait as closure over instruction allows us the same behaviour.