Add an IPTC parser #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
November 7, 2018 20:48
blueimp
approved these changes
Nov 11, 2018
There was a problem hiding this comment.
@bevand10, this is the best pull request I've ever retrieved for any of my open source projects:
- Adds super useful new functionality ✔️
- Follows existing coding style ✔️
- Builds on top of existing conventions ✔️
- Adds relevant options ✔️
- Adds unit tests covering new functionality ✔️
- Adds documentation for new functionality ✔️
- Adds demo for new functionality ✔️
- Extends relevant package meta data ✔️
- Includes links to specs and reference documentation ✔️
- Friendly pull request message ✔️
Thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I've added a IPTC parser, modelled after the existing exif parser.
Hope this works for you?
It correctly parses the three IPTC reference images made available at https://iptc.org/standards/photo-metadata/iptc-standard/:
--Dave.