This repository was archived by the owner on May 25, 2023. It is now read-only.
Update UploadHandler.php (fixed) #3496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 14, 2017 20:45
- fixed indentation - fixed spelling error - restored a commented-out array as example of 'another version' of the image - moved max_width, max_height comments
Improved code based upon comments.
|
No worries, I don't expect every contributor to be intricately familiar with GitHub. If you want to add changes to an existing pull request, you can simply push additional commits to the branch where you started the pull request from. |
blueimp
suggested changes
Nov 19, 2017
| 'max_width' => 80, | ||
| 'max_height' => 80 | ||
| ), | ||
| */ |
There was a problem hiding this comment.
I still prefer the existing medium example, but I prefer your more descriptive comment line.
jbostoen
commented
Nov 19, 2017
- example renamed to 'medium', different width/height than thumbnail
blueimp
suggested changes
Nov 19, 2017
| 'max_width' => 200, | ||
| 'max_height' => 160 | ||
| ), | ||
| */ |
There was a problem hiding this comment.
Again, please keep the original dimensions for the example.
Changing sample dimensions should only be done if there's a good reason for it.
blueimp
approved these changes
Nov 20, 2017
|
Thanks @jbostoen ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I'm still new to Github and couldn't change my previous request, so I forked the project and created this commit.
Based on a use case I've encountered:
Implemented changes based upon comments.