Full tx subscription missing 'from' field into transaction details

[julesGoullee]

System information

OS & Version: OSX
Commit hash : 34b065a

When subscribing to the pending transactions with the fullTx parameter the field from is missing, which is inconsistent with native geth and also expected from a library like etherjs

@lmittmann

[weiihann]

Can you show the method of reproducing it (i.e. commands)?

[julesGoullee]

It's related to pending transaction filter with full tx: eth_subscribe, this have been introduce here #1626

[joseddg92]

Here is a way to reproduce it:

import logging

from web3 import Web3

IPC_PATH = "/root/test-bsc-node/node/geth.ipc"

w3 = Web3(Web3.IPCProvider(IPC_PATH))
def _pending_tx_loop():
    tx_filter = w3.eth.filter('pending')
    while True:
        try:
            new_pending_txs = tx_filter.get_new_entries()
            for tx in new_pending_txs:
                print(f"{tx}")
        except ValueError:
            logging.exception("_pending_tx_loop")


def main():
    _pending_tx_loop()


if __name__ == "__main__":
    main()

[weiihann]

Hello :) thanks for providing the details. I did some code digging and here's the outcome:

Essentially, #1626 was a cherry-pick PR for this feature, but it wasn't a complete one. Upon investigation, I found that we also need to merge these geth PRs:

1. eth/filters: add global block logs cache ethereum/go-ethereum#25459
2. eth/filters: send rpctransactions in pending-subscription ethereum/go-ethereum#26126
3. eth/filters: fix a breaking change and return rpctransaction ethereum/go-ethereum#26757

One of our team members is working on merging all the past PRs from geth to BSC, and expect it would be live sometime next month. By that time, this feature should be completely resolved.

Hope that helps!

[joseddg92]

Very unfortunate that, due to the fork, updating is mandatory now. And this fiuncionality is broken.

[canhlinh]

until now this bug hasn't fixed.

[zzzckck]

until now this bug hasn't fixed.

Noted, will double check this issue.

[zlacfzy]

until now this bug hasn't fixed.

Haven't reproduce. Seem not miss from field. @canhlinh
{ "jsonrpc": "2.0", "method": "eth_subscription", "params": { "subscription": "0xb4205b40bf98e772d128e6572dbf50ae", "result": { "blockHash": null, "blockNumber": null, "from": "0xa23c9035afd3e34690d80804b33bdf1b93c0a604", "gas": "0x757da6", "gasPrice": "0x12d00e280", "hash": "0xa7e90018efae47d687beafc9333dcd88a60a885a335415af84d82b402e106c97", "input": "", "nonce": "0xea70", "to": "0x5ff137d4b0fdcd49dca30c7cf57e578a026d2789", "transactionIndex": null, "value": "0x0", "type": "0x0", "chainId": "0x61", "v": "0xe5", "r": "0xaf6a41e7323e7e7e6abb5c6bbcd1bfc94a97abd81dbe6ddda5a22c0128f4761d", "s": "0x548d7a94a56f574260a1758d394ae435f1d1f6502da2229d8fc21881e92efa40" } } }