Skip to content

Support aggregation specifier symbol @ in metric names for mix aggregation policy #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bom-d-van wants to merge 2 commits into from
Closed

Support aggregation specifier symbol @ in metric names for mix aggregation policy #226

bom-d-van wants to merge 2 commits into from

Conversation

@bom-d-van
Copy link
Collaborator

@bom-d-van bom-d-van commented Dec 31, 2019

Hi, this is for supporting mix aggregation policy implemented for cwhisper and go-carbon.

Relevant PRs:
go-graphite/go-whisper#5
https://github.com/lomik/go-carbon/pull/331/files

@grzkv
Copy link
Member

grzkv commented Jan 22, 2020 •
edited
Loading

I see that the support for this aggregation is a draft in go-carbon. Is this needed now or is it for later?

@grzkv
Copy link
Member

grzkv commented Jan 24, 2020

@bom-d-van ^^^

@bom-d-van
Copy link
Collaborator Author

bom-d-van commented Jan 25, 2020

Hi @grzkv, sorry, just saw your message. Yeah, the changes in go-carbon is in draft. This is currently for early preview and it's pretty minor change. Had some discussions with @azhiltsov few weeks ago.
Will come back here once we have the changes moved forward in go-carbon.

@grzkv grzkv self-assigned this Jan 25, 2020
@grzkv
Copy link
Member

grzkv commented Jan 27, 2020

I think it makes sense to wait until the changes to go-carbon are merged. I guess this PR requires that to happen to make sense.

@avereha avereha added the wip label Jul 10, 2020
@grzkv grzkv marked this pull request as draft July 10, 2020 14:45
@grzkv grzkv removed the wip label Jul 10, 2020
@grzkv grzkv removed their assignment Jul 10, 2020
@grzkv grzkv closed this Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grzkv grzkv Awaiting requested review from grzkv grzkv will be requested when the pull request is marked ready for review grzkv is a code owner

@azhiltsov azhiltsov Awaiting requested review from azhiltsov azhiltsov will be requested when the pull request is marked ready for review azhiltsov is a code owner

@timtofan timtofan Awaiting requested review from timtofan timtofan will be requested when the pull request is marked ready for review timtofan is a code owner

@emadolsky emadolsky Awaiting requested review from emadolsky emadolsky will be requested when the pull request is marked ready for review emadolsky is a code owner

@deniszh deniszh Awaiting requested review from deniszh deniszh will be requested when the pull request is marked ready for review deniszh is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bom-d-van @grzkv @avereha