-
Notifications
You must be signed in to change notification settings - Fork 32
Upgrade DOCBOOK_XSL_VERSION #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
build_docs is interesting, didn't know about that. |
|
Someone got errors building the docs for Boost.Core, and this pull request would fix it. |
There is a |
|
And by the way, the project moved to GitHub, and there already was a 1.79.2 release: https://github.com/docbook/xslt10-stylesheets/releases/tag/release%2F1.79.2 |
|
Anyway... since it has been over a year with no progress merging this, I think it is safe to close it. Note that we are moving away from the Quickbook toolchain because it is not being actively maintained and developed. Instead we are focusing on Asciidoctor. |
|
I'm certainly not moving away from QuickBook. |
No one is asking you to. The "we" in my statement above refers to myself, Peter Dimov, Glen Fernandes, Rene Morell, all C++ Alliance Staff Engineers, and any other library author or maintainers who want to update to a modern, well-supported toolchain. |
| # User configuration | ||
| # (MAINTANERS: please, keep in synch with setup_boostbook.sh) | ||
| DOCBOOK_XSL_VERSION = "1.75.2" | ||
| DOCBOOK_XSL_VERSION = "1.79.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 1.79.2 (the newest) gives errors in the chunking. The documentation is not correct anymore with the parameters supplied in current Jamfiles (at least, not for Boost.Geometry). It misses all tables of contents (apart from the one on the main page). Effectively it's completely broken.
That's likely the case with 1.79.1 as well, given that it is one patch lower.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With version 1.79.1 , generation of Boost.Geometry is correct!
Per a request, this updates DOCBOOK_XSL_VERSION from 1.75.2 to 1.79.1, and switches to the zip file download because the tar.gz archive isn't available.
As far as the general topic of installing the docs toolchain, these scripts at https://github.com/boostorg/release-tools/tree/develop/build_docs are able to install necessary apt, gem, and pip packages, and build docs for boost libraries. So it's probably not necessary to extensively enhance
setup_boostbook.sh, just use thebuild_docsscripts.