Skip to content

Fix node 20 issue on GHA CI #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Flamefire wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix node 20 issue on GHA CI #15

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9fa56ae
Fix node 20 issue on GHA CI
Flamefire Dec 7, 2024
e9dc00e
Use hosted node
Flamefire Dec 8, 2024
d9d1037
Update containers
Flamefire Dec 8, 2024
bca79aa
Remove macos-12 from GHA
Flamefire Dec 8, 2024
ddb1186
Install xz
Flamefire Dec 8, 2024
a69c50b
GHA: Remove C++2b test from clang-17 on ubuntu-24.04
Flamefire Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix node 20 issue on GHA CI
  • Loading branch information
@Flamefire
Flamefire authored Dec 7, 2024
commit 9fa56ae04e8eee469e0796b87cf78b215e3a83b4
20 changes: 12 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,24 +180,28 @@ jobs:
os: macos-14

runs-on: ${{matrix.os}}
container: ${{matrix.container}}
container:
image: ${{matrix.container}}
volumes:
- /node20217:/node20217:rw,rshared
- ${{ startsWith(matrix.container, 'ubuntu:1') && '/node20217:/__e/node20:ro,rshared' || ' ' }}

defaults:
run:
shell: bash

steps:
- name: Enable Node 16
run: |
echo "ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true" >> $GITHUB_ENV

- uses: actions/checkout@v3

- name: Setup container environment
if: matrix.container
run: |
apt-get update
apt-get -y install sudo python3 git g++
apt-get -y install sudo python3 git g++ curl
if [[ "${{matrix.container}}" == "ubuntu:1"* ]]; then
# Node 20 doesn't work with Ubuntu 16/18 glibc: https://github.com/actions/checkout/issues/1590
curl -sL https://unofficial-builds.nodejs.org/download/release/v20.9.0/node-v20.9.0-linux-x64-glibc-217.tar.xz | tar -xJ --strip-components 1 -C /node20217
fi

- uses: actions/checkout@v4

- name: Install packages
if: matrix.install
Expand Down
Loading