Add if constexpr macro and replace condition macro. #1168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awulkiew
force-pushed
the
feature/constexpr
branch
from
c6e83fd to
9684581
Compare
barendgehrels
approved these changes
Jul 2, 2023
Collaborator
barendgehrels
left a comment
barendgehrels
left a comment
There was a problem hiding this comment.
I agree with this approach, thank you!
| #define BOOST_GEOMETRY_CONSTEXPR(CONDITION) (BOOST_GEOMETRY_CONDITION(CONDITION)) | ||
|
|
||
| #endif | ||
|
|
|
|
||
| collection.get_turns(); | ||
| if (BOOST_GEOMETRY_CONDITION(areal)) | ||
| if BOOST_GEOMETRY_CONSTEXPR (areal) |
| { | ||
| collection.discard_nonintersecting_deflated_rings(); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Looks better than the original code
Member
Author
|
@vissarion Thanks! This wasn't finished though. I'll create another PR with the rest. :) |
Member
I know. I just merged it since there were the 1.83 and the enhancement labels and the beta is closing today. I guess there is no problem to have the rest of the support in 1.84. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal adding conditional support of C++17
if constexpr. I modified only several files for now so we can start a discussion. If we have an agreement I'll modify other places.My intention was to have a solution as close as possible to the original language feature and to keep
ifkeyword so editors can highlight it as usual, i.e.:vs
It's a followup of #1160