Skip to content

Conversation

@barendgehrels
Copy link
Collaborator

This fixes #834 and two additional new compiler warnings

Copy link
Member

@vissarion vissarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but tests are failing on clang-9.

@barendgehrels
Copy link
Collaborator Author

Looks OK, but tests are failing on clang-9.

Must be a false negative

 In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/mutex:39:
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/chrono:1345:24: error: unknown type name 'strong_ordering'
      friend constexpr strong_ordering

@barendgehrels
Copy link
Collaborator Author

I'm running them again

@awulkiew
Copy link
Member

Yes, it seems that clang-9 problem is not in Geometry. I think it may be ignored.

@barendgehrels barendgehrels merged commit 1a3f425 into boostorg:develop May 19, 2021
@barendgehrels barendgehrels deleted the fix/compiler_warnings_834 branch May 19, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WSVC Warning C4456: declaration of 'side_pk_q1' hides previous local declaration

3 participants