Skip to content

Drop execute bit for C++ code #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
barendgehrels merged 1 commit into from
Dec 15, 2021
Merged

Drop execute bit for C++ code #950

barendgehrels merged 1 commit into from
Dec 15, 2021

Conversation

@hdu-sdlzx
Copy link
Contributor

@hdu-sdlzx hdu-sdlzx commented Dec 11, 2021

C++ code files do not need this.

@awulkiew
Copy link
Member

awulkiew commented Dec 11, 2021 •
edited
Loading

This looks wrong. Could you elaborate on what did you want to do?

Ok I get it. It's about file attributes/permissions.

barendgehrels
barendgehrels approved these changes Dec 12, 2021
View reviewed changes
Copy link
Collaborator

@barendgehrels barendgehrels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vissarion
Copy link
Member

vissarion commented Dec 14, 2021

Thanks! The commit message could read "Drop execute bit for C++ source code files" to be more clear.

@vissarion vissarion self-requested a review December 14, 2021 10:56
@barendgehrels barendgehrels merged commit b54c8c9 into boostorg:develop Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barendgehrels barendgehrels barendgehrels approved these changes

@vissarion vissarion vissarion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hdu-sdlzx @awulkiew @vissarion @barendgehrels