Improve coverage for string #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #42 +/- ##
===========================================
+ Coverage 98.2% 99.09% +0.88%
===========================================
Files 57 57
Lines 4856 4854 -2
===========================================
+ Hits 4769 4810 +41
+ Misses 87 44 -43
Continue to review full report at Codecov.
|
sdkrystian
force-pushed
the
develop
branch
7 times, most recently
from
f9c9212 to
2217fdf
Compare
vinniefalco
reviewed
Feb 21, 2020
| const bool inside = detail::ptr_in_range(curr_data, curr_data + curr_size, s); | ||
| // there is nothing to replace; return | ||
| if (inside && s - curr_data == pos && n1 == n2) | ||
| if (inside && std::size_t(s - curr_data) == pos && n1 == n2) |
Member
There was a problem hiding this comment.
Can we please use static_cast so it sticks out?
Member
Author
There was a problem hiding this comment.
Alright, this has been addressed
Member
|
Merged, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.