Updates #60
Merged
Updates #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Boost-wide convention is to call project with BOOST_SUPERPROJECT_VERSION
CMake build as part of Boost superproject is still experimental - added comments where things needs to be clarified - call boost_install for Boost superproject mode - do not build bench and example, just test
Two build scenarios need to be tested and configured for GitHub Actions: - CMake build as part of Boost superproject - CMake build as out-of-tree, non-standalone build - this one is unclear, seems equivalent to BOOST_JSON_FIND_BOOST mode
Codecov Report
@@ Coverage Diff @@
## develop #60 +/- ##
========================================
Coverage 99.09% 99.09%
========================================
Files 57 57
Lines 4861 4861
========================================
Hits 4817 4817
Misses 44 44Continue to review full report at Codecov.
|
Flamefire
reviewed
Mar 18, 2020
Flamefire
reviewed
Mar 18, 2020
Flamefire
reviewed
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.