Skip to content

Update kolmogorov quantile newton ub to 1 #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mborland merged 4 commits into from
Jul 31, 2023
Merged

Update kolmogorov quantile newton ub to 1 #1002

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37ba5a4
change kolmogorov quantile Newton ub from max to 1
ryanelandt Jul 25, 2023
b612afa
remove no longer needed newton step size logic
ryanelandt Jul 25, 2023
6bf5125
add infinity skew test back
ryanelandt Jul 25, 2023
e7ada7f
do not use Inf for Newton Bounds
ryanelandt Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
do not use Inf for Newton Bounds
  • Loading branch information
@ryanelandt
ryanelandt committed Jul 25, 2023
commit e7ada7f6fe30f777bf42af69ffbb6542b134e588
4 changes: 2 additions & 2 deletions include/boost/math/distributions/skew_normal.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,8 +676,8 @@ namespace boost{ namespace math{

// refine the result by numerically searching the root of (p-cdf)

const RealType search_min = range(dist).first;
const RealType search_max = range(dist).second;
const RealType search_min = support(dist).first;
const RealType search_max = support(dist).second;

const int get_digits = policies::digits<RealType, Policy>();// get digits from policy,
std::uintmax_t m = policies::get_max_root_iterations<Policy>(); // and max iterations.
Expand Down