fixed CSS property in doc/math.css

[suyash-patil]

No description provided.

[NAThompson]

@suyash-patil : Is there a place in the docs that inspired this fix? I'd like to validate it . . .

[suyash-patil]

As I was going through the files, I saw that this is an invalid syntax in CSS. That is why I fixed this.

[pabristow]

As far as I know, the existing code 'works' - in that things that are supposed to be red are displayed as red.
It would clearly be better not to have invalid items, even if they work at present.

@suyash-patil Can you explain what tool or knowledge found this?

But I'm re-building some Quickbook docs soon and I'll check out the proposed correction to make quite sure it still works.

[suyash-patil]

@pabristow: Actually, I opened the file and the text editor highlighted the syntax error. It has a value (inline-block) but has no key (should be "display"). In that way, I figured out the error.

[pabristow]

Thanks - sounds simple enough. I'll check it out unless someone else beats me to it.

[pabristow]

I've start to look at this, but may be a little more complicated than I thought.

@suyash-patil is correct that there is a missing display:

The color feature was a late addition to Quickbook, used in the production of the math docs, so we do not seem to have used it much. The main use is in table of performance where worse performance is show in red and better in green or reference in blue.

There are a few uses in the text like "Warning code may explode" ;-)

The other use is a tick or cross symbol, but this is done using a Unicode symbol, so counts as text?

I am puzzled at why red has been chose for special treatment?

From my reading of

https://stackoverflow.com/questions/3043021/is-there-any-guide-on-when-to-use-displayblock-when-inline-and-when-inline-b#:~:text=The%20use%20cases%20for%20block,it%27s%20used%20naturally%20for%20images.

suggests that display:inline would be most suitable when it is a text item like "1.2345".

(whereas display: inline-block for a graphic, but does allow height and width specification so perhaps this is right?)

But I am not an expert on this. Any more informed views?

@jzmaddock probably remembers something about this?

And I presume that the same 'display: inline' should be applied to all colors, not just red?

(Aside: colors are also use in Boost. Multiprecision and probably other libraries too - this should perhaps be in boostbook.css?)

[suyash-patil]

@pabristow Can you please tell me how to pass the travis CI build test at the time of making PRs?

[pabristow]

In the absence of comments on this issue, I propose to set all the colors to use your suggestion, so I don't think you need to bother further with a PR for a trivial (but useful) proposal, for which thanks.

(And anyway, I am a Travis novice and I don't know the answer to your question :-( )

[jzmaddock]

You can ignore the Travis failure - someone has merged code that had failures - I've left a message about that elsewhere. In the meantime I see no reason not to just merge this as is?

[pabristow]

commit commit f304c83 adds display:inline-block; for all colors in math.css.

(Some experiments show that color can be applied to many items, including equations in red using the Quickbook [role red Some red text]. Could be more widely used?)